Updating code owners to cover all CRI teams #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merlinc
requested changes
Aug 16, 2024
There was a problem hiding this comment.
@gds-jbentham AIUI the plan was to restrict the CodeOwners to the various admins + appropriate FE developers, rather than open it up to every developer on each CRI teams
(also, the CODEOWNERS contains errors)
merlinc
reviewed
Sep 13, 2024
| @@ -1 +1 @@ | |||
| * @govuk-one-login/cri-orange-team @govuk-one-login/cri-orange-admins @govuk-one-login/cri-lime-team-leads @govuk-one-login/identity-sre # Team ownership with break-glass overrides | |||
| * @govuk-one-login/cri-orange-team @govuk-one-login/cri-orange-admins @govuk-one-login/cri-lime-team-leads @govuk-one-login/cri-lime-team @govuk-one-login/kiwi-admins @govuk-one-login/kiwi-devs @govuk-one-login/identity-sre # Team ownership with break-glass overrides | |||
There was a problem hiding this comment.
After discussion with @gds-jbentham this should be:
Suggested change
| * @govuk-one-login/cri-orange-team @govuk-one-login/cri-orange-admins @govuk-one-login/cri-lime-team-leads @govuk-one-login/cri-lime-team @govuk-one-login/kiwi-admins @govuk-one-login/kiwi-devs @govuk-one-login/identity-sre # Team ownership with break-glass overrides | |
| * @govuk-one-login/cri-lime-team-leads @govuk-one-login/cri-orange-leads @govuk-one-login/kiwi-admins @govuk-one-login/identity-sre-leads @govuk-one-login/cri-frontend-team # Team ownership with break-glass overrides |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Updated code owners file to cover devs across all CRIs
Why did it change
To allow joint ownership of the common-express repo